@John I agree, but I also have plugins that get errors when the install script tries to create things twice (because it's already run before) which isn't great.

I'll keep the data loss issue in mind when I look at this, I think any option to uninstall completely should have a big enough warning on it for admins not to do it accidentally.

I think maybe adding something like 'disable' and 'uninstall' as separate options might work.

I've copied your feedback over to the github issue too so I don't miss it later: https://github.com/ushahidi/Ushahidi_Web/issues/328

On Thu, Mar 15, 2012 at 10:04 AM, Antonio Lettieri <alettieri@...> wrote:

That's a good point. 

I think there should still be an option to fully delete the plugin along with whatever it crated in the database though. Some plugins may depend on the process of deleting and re-creating tables, plus I don't think the database should be left with rogue tables in place when they're not being used after a plugin has been uninstalled. 

Having the option to deactivate a plugin as in John's case would be helpful too.

On Wed, Mar 14, 2012 at 1:57 PM, john.etherton@... <john.etherton@...> wrote:

Yup, I agree it does nothing. And honestly, I kinda like it this way.

The fact that uninstall is never called means you can "uninstall" then "install" as a way to "reinstall" with out disrupting the database. This is something I do all the time, since I want to upgrade code and tables with out removing the data that's already there.

A lot of the plugins I work on create large amounts of data and their loss would be detrimental. It scares the hell out of me that any admin could delete a plugin with only a generic error message between them and total data annihilation.

John Etherton
+1-404-587-1606
john.etherton@...

On 3/14/12 2:11 PM, Antonio Lettieri wrote:

http://sadtrombone.com/

On Wed, Mar 14, 2012 at 11:09 AM, Rob Baker <rrbaker@...> wrote:

+1

On Wednesday, March 14, 2012 at 2:07 PM, George Chamales wrote:

I've never seen it wired to anything.

George Chamales
Rogue Genius LLC

http://roguegenius.com
Phone:  718.288.7718
Skype:  notgeorge

On Wed, Mar 14, 2012 at 11:06 AM, Mr. Evoltech <evoltech@...> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When does it get called?

I am not seeing anywhere that plugins uninstall() method is actually
ever called.  Am I missing something? I see that
Plugins_Controller::index() will call this functionality when
$post->action == 'd' but I dont see anywhere in views that this is
done.  I also dont see anywher in the directory scanning logic where
this might be performed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPYN41AAoJEDTy25qNIucjzNQQALouwmwzXEWyMIoTZG5sTIdr
NI1FXOAPqsyjNn8AibsDpuHbfeiGvHG6Esqzh+Bevop7eTV3z39DZ8xcm2rME5oc
xFDNO83Ou9bhsaXOWrAlciWB86fYb2lkLlAOxf6K2SWZnwNX5SSTxpkybDVJGiGp
o+mgwIfQtgo4EaJ6+D513Ru3uFaf5qpTmWFS57/5cy8FG/mI9g3yg1Q1XU4rGtqj
9O3t51dl/qfonVgCav8vgIUi5ccdBY87NUqpy1Fzr+lssY/mO51MxK4TygjWRDrU
9FAiKoXkFUcdDM3fcS4AXrME0oFCc5g7WqgR2XsLLgPUNaIHMnWomr0NLrL/ibDJ
26meDyjyXGA2HzN80QnyG8FGXUBDfaPPKt4L64KjjHJ6h26KH/Yd2Y/Tw3ADed+n
1yJ5zsc5eToLx8ddEjvzzzGLv9buzMi7wZqoVle98YfBOM/T+w9JGeJUcOxrfP2E
TRNMkx5uwhgoJbvVWyzLOp3z1nDxQKtRnlS0MbmySZPEIhhGONeN5V1xlA2FSCiu
0VmmVzr0ApLrTQJoR8fhhYfEqcxjIsr1K+a+u4NK+rustm3gp2qYUFxT4HIc/Hx5
yRpP1nikr3dgUgr3qv5NwoROBZB85m7cwUr3a1EjDOMDOoeOAI1AS/1NHs9+dXpE
Dd60EGR4YOmOqMn9sUd4
=w5Xv
-----END PGP SIGNATURE-----




~~~~~~~~~~~~~~~~~~~~~~~~~~
List Archive: http://list.ushahidi.com/

Would you like to receive list mail batched in a daily digest instead? Send a message to:
developers-digest-subscribe@...

To remove your address from the list, just send a message to
the address in the "List-Unsubscribe" header of any list
message. If you haven't changed addresses since subscribing,
you can also send a message to:
developers-unsubscribe@...

For addition or removal of addresses, we'll send a confirmation
message to that address. When you receive it, simply reply to it
to complete the transaction.

If you need to get in touch with the human owner of this list,
please send a message to:
developers-owner@...

--
Antonio

site: webtonio.com
twitter: alettieri

--
Antonio

site: webtonio.com
twitter: alettieri