Thanks for the feedback Evoltech. I would definitely recommend a pull request. Even better would be filing a new issue with a corresponding pull request that closes it.<br><br>Logging IP Addresses for an API request is not a big deal (to prevent abuse) except that our original implementation was not the best. A REMOTE_ADDR would be sufficient on our end instead of explicitly defining it in the request.<br>

<br>David.<br><br><br><br>
<br><br><div class="gmail_quote">On Wed, Feb 8, 2012 at 12:13 AM, Mr. Evoltech <span dir="ltr">&lt;<a href="mailto:evoltech@...">evoltech@...</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Also please see attached a patch that will fix /admin/upgrade from
    crashing if this scenario happens again.  I can also submit a pull
    request if you want.<br>
    <br>
    On another note, I am not sure why yall are passing the ip address
    as a parameter to the call home url, as if you actually wanted the
    ip address that the machine calling home from was you could just get
    that from the web server, and it also raised a, &quot;why are they
    collecting this PII?&quot;<br>
    <br>
    Sincerely,<br>
    evoltech<div class="im"><br>
    <br>
    On 02/07/2012 08:57 PM, Mr. Evoltech wrote:<br>
    <span style="white-space:pre-wrap">&gt;</span><br>
    <blockquote type="cite">Not sure if anyone has seen this but the
      upgrade server is giving error<br>
      messages that is causing /admin/upgrade to crash.<br>
      <br>
      ie:<br>
<a href="http://version.ushahidi.com/2/?v=2.1&amp;u=ushahidi.march-hare.org%2F&amp;ip=127.0.0.1" target="_blank">http://version.ushahidi.com/2/?v=2.1&amp;u=ushahidi.march-hare.org%2F&amp;ip=127.0.0.1</a><br>
      <br>
      I suspect this is an issue with an upgrade to php that was done on
      the<br>
      server<br>
    </blockquote>
    <span style="white-space:pre-wrap">&gt;</span><br>
    <br>
    <br>
  </div></div>

<br><br>
<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
List Archive: <a href="http://list.ushahidi.com/" target="_blank">http://list.ushahidi.com/</a><br>
<br>
Would you like to receive list mail batched in a daily digest instead? Send a message to:<br>
<a href="mailto:developers-digest-subscribe@...">developers-digest-subscribe@...</a><br>
<br>
To remove your address from the list, just send a message to<br>
the address in the &quot;List-Unsubscribe&quot; header of any list<br>
message. If you haven&#39;t changed addresses since subscribing,<br>
you can also send a message to:<br>
<a href="mailto:developers-unsubscribe@...">developers-unsubscribe@...</a><br>
<br>
For addition or removal of addresses, we&#39;ll send a confirmation<br>
message to that address. When you receive it, simply reply to it<br>
to complete the transaction.<br>
<br>
If you need to get in touch with the human owner of this list,<br>
please send a message to:<br>
<a href="mailto:developers-owner@...">developers-owner@...</a><br></blockquote></div><br>